Back to General and Gameplay Programming

See Anything I missed(source)

Esap1 · 2000-07-05T00:13:34

PLEASE SCROLL TO BOTTOM! I was hoping it wouldnt come to this but I just cant figure out the problem. This function loads an ASE file. But it crashes when I have more Texture Coordinates than number of Vertices. Heres the classes. (Sorry for the length). class Map_class { public: Object_class *Object; long numObjects; int LoadASE(char *file); int DrawMap(); }; class Object_class { public: //unsigned int VertexIndex[MAX_INDEX]; Vertex_class *Vertex; Face_class *Face; unsigned int numVertex; unsigned int numFace; unsigned int Texture; float *tu; //Pointer to the list of TU's float *tv; //Pointer to the list of TV's int active; int Draw(); Object_class(){active=1;} inline Object_class &operator = (Object_class &O); }; struct Face_class { unsigned int Index[3]; unsigned long TexIndex[3]; //Texture Coord Index Vertex_class Normal; inline Face_class &operator = (Face_class &F); Face_class(){Index[0]=Index[1]=Index[2]=0;} }; struct Vertex_class { float x,y,z; inline Vertex_class &operator = (Vertex_class &V); }; ------------------------------------------------------ And heres the function. int Map_class::LoadASE(char *filename) { int done=0; char temp[32]; char temp2[32]; unsigned long index1,index2,index3; unsigned long Mesh_NumVertex=0; unsigned long Mesh_NumFaces=0; unsigned long Mesh_NumTVertex=0; unsigned long Mesh_NumTVFaces=0; unsigned long currObject=0; unsigned long numObject=1; unsigned long currTVertex=0; unsigned long currFace=0; unsigned long currTVFace=0; float ftemp; Object_class TempObject; FILE *fp; fp = fopen(filename,"r"); if(fp<=0){return -1;} //Find Out How many Objects there are in the file while(fscanf(fp,"%s",&temp)!=EOF) { if(strcmp(temp,"*MESH_NUMVERTEX")==0) { numObject+=1; } } fseek(fp,0,SEEK_SET); Console.Print("Loading ASE "); Console.Print(filename); //Alocate enough space for the objects Object = new Object_class[numObject]; while(done!=1) { //Find MESH_NUMVERTEX while(strcmp(temp,"*MESH_NUMVERTEX")!=0)if(fscanf(fp,"%s",&temp)==EOF){goto DONE1;} if(fscanf(fp,"%d",&Mesh_NumVertex)==EOF)goto END1; Object[currObject].Vertex = new Vertex_class[Mesh_NumVertex]; //Get MESH_NUMFACES while(strcmp(temp,"*MESH_NUMFACES")!=0)if(fscanf(fp,"%s",&temp)==EOF)goto END1; if(fscanf(fp,"%d",&Mesh_NumFaces)==EOF)goto END1; Object[currObject].Face = new Face_class[Mesh_NumFaces]; //Find MESH_VERTEX while(strcmp(temp,"*MESH_VERTEX")!=0)if(fscanf(fp,"%s",&temp)==EOF)goto END1; //Get First Vertex if(fscanf(fp,"%d",&index1)==EOF)goto END1; //fscanf(fp, "%f %f %f",&Object[currObject].Vertex[0].x, &Object[currObject].Vertex[0].z, &Object[currObject].Vertex[0].y); if(fscanf(fp,"%f",&Object[currObject].Vertex[0].x)==EOF)goto END1; if(fscanf(fp,"%f",&Object[currObject].Vertex[0].z)==EOF)goto END1; if(fscanf(fp,"%f",&Object[currObject].Vertex[0].y)==EOF)goto END1; for(unsigned int currVertex=1; currVertex

General and Gameplay Programming Programming

Started by Esap1 July 01, 2000 09:26 PM

10 comments, last by Esap1 24 years, 5 months ago

GayleSaver

122

July 04, 2000 06:34 PM

"Ewww GOTOs"?

Erm....sometimes GOTOs can save time...

If you really want to be structured, you''re not even allowed to return early from a function but rather must save the value in a variable and force control to fall through, so...

Screw the structure when performance is needed, and keep it if you want readable code. Personally I don''t see why a few GOTOs are bad.

zenic

122

July 05, 2000 12:13 AM

okay, i haven''t looked through it properly, but...

1. at first glance i cant see where you are deleting Object.
(remember to use delete []Object

2. you are defining temp as 32 charcters. and then using fscanf.
i wouldn''t do that... the string could be longer then 32 chars!
(imagine a corrupt file) and will crash if it is.
try to set temp to be 8000 or so for now, with a view to replace
it in the future. near future.

PS: STL stands for "Standard Template Library".

See Anything I missed(source)

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

See Anything I missed(source)

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines