My programming style

Denis Ivanov · 2013-04-29T19:49:15

Share a few lines of code that exemplify your programming style. Share innovations. I'll start. void UpdateAI() { CPlayer* p; for(int i=0; i<PLAYERS; i++) { p = &g_player; if(!p->on) continue; if(!p->ai) continue; UpdateAI(p); } } Features: - Use pointers with one, first letter of word of type (CPlayer* p, CUnit* u, CUnitType* t, CCamera* c, CClient* c, CEntity* e, CPacket* p) or purpose (position, radius) - Use this pointer instead of fully qualified variable reference - Use a single line for each continue if-statement condition - Part object-oriented, part procedure-oriented Another example: bool CollidesWithUnits(float x, float z, float hwx, float hwz, bool isUnit, CUnit* thisU, CUnit* ignore, bool checkPass) { CUnit* u; CUnitType* t; float r; CVector3 p; CCamera* c; for(int i=0; i<UNITS; i++) { u = &g_unit; // <-- if(!u->on) continue; if(u == ignore) continue; if(u == thisU) continue; t = &g_unitType[u->type]; // <-- //... c = &u->camera; // <-- p = c->Position(); // <-- r = t->radius; // <-- //... } return false; } - Multiple levels of pointers retrieving something from other pointers Instead of nesting if-statements, bool CWidget::DropDown_prelbuttonup() { if(ldown) { ldown = false; if(opened) { if(mousescroll) { mousescroll = false; return true; // intercept mouse event } for(...) { // list item? if(...) { //.... opened = false; return true; // intercept mouse event } } // up button? if(...) { //... return true; } // down button? if(...) { //... return true; } opened = false; return true; // intercept mouse event } return false; } return false; } I try to write if(!...) return; whenever I can, so that it looks like this: bool CWidget::DropDown_prelbuttonup() { if(!ldown) return false; ldown = false; if(!opened) return false; if(mousescroll) { mousescroll = false; return true; // intercept mouse event } for(...) { // list item? if(...) { //.... opened = false; return true; // intercept mouse event } } // up button? if(...) { //... return true; } // down button? if(...) { //... return true; } opened = false; return true; // intercept mouse event } This was a big paradigm shift for me, when I first thought of this. But now I do it all the time.

GDNet Lounge Community

Started by polyfrag April 26, 2013 05:47 AM

42 comments, last by jpetrie 11 years, 6 months ago

polyfrag

Author

2,504

April 29, 2013 12:51 PM

BTW, that is obviously C++ http://www.gamedev.net/topic/642323-my-programming-style/page-2#entry5057696

https://dev.visucore.com/doom3/doxygen/classid_str.html

Can't be old code.

kunos

2,256

April 29, 2013 02:05 PM

dude what's wrong with u? Seriously.. Doom3 was released in 2004!! By a guy famous for being "late to the C++ party".... with a 3 year typical dev time.. the code probably started in 2001... with a lot of cut & paste from older engines.

Do you realize it's 2013 don't you? Compilers are fine, computers are fine.. C++11 is almost a decent language to work with.. optimization techniques do not rely on those stuff anymore.. it's all about memory access and multithread and COMPLEXITY MANAGEMENT.. you are trying to solve problems that dont even exist anymore.

Stefano Casillo
TWITTER: [twitter]KunosStefano[/twitter]
AssettoCorsa - netKar PRO - Kunos Simulazioni

Juliean

7,364

April 29, 2013 04:22 PM

I smell hypocrazy. You talk about innovation, and yet you show code from +10 years ago to justify your inferior coding conventions. I'm not sure, something doesn't sound right here... somebody help me out plz?

</irony>

Seriously, even if those out-dated code sources were actually the way to take your coding style from... what would be so special about your coding style then? I mean, why don't I make such a thread, claming to have developed the next best coding convention, by using the "const" keyword to disallow modification of variables in my program. Yeah, totally frigging awesome, nobody would have thought about that. (damn, irony wasn't really off). And if what gets written in such a wasn't so obviously right, but outdated and rather beginner-ish, you should be fully accepting of the fact you are getting criticised and offered constructive help, rather than calling the other, more experienced people wrong.

SERIOUSLY, whats up with people nowadays? Whats so hard at accepting you are wrong? Not aimed at the OP directly, but everybody and their sister tries to justify all their actions up until the end, even if it is obvious they are wrong, bringing the most ludacris excuses / "proofs" they are right. Whats so hard on saying " oh, yeah, I see now, I was wrong, thanks for offering me a better way" ? But, I digress...

jpetrie

13,223

April 29, 2013 07:49 PM

This topic was of questionable utility to begin with and has degenerated significantly from there, so I'm locking it. I've also restored attempts on the part of some users to sanitize the thread by deleting their posts. Please don't engage in such childish behavior.

Have a nice day.

My programming style

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

My programming style

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines