Finally done with my Pong clone! download it from http://www.gamedev.net/community/gds/projects/default.asp?projectID=273 Tell me what you thing about the game and what you thing about the sourcecode(included). What do you think about the code? Was the code clean and well commented? Was it efficient? Some things I should have done differently? Newbish mistakes? Did you like the game? Thanks alot for your replies

Your zip file has errors with the CRC for some of the files. I was able to extract most files except for the executable. Try re-making your zip file and uploading it again.

OK, I''ve uploaded another zip file, if it doesn''t work please inform me.

Thanks

Lalle

The game was fun, and it did seem like you put a little more work in it than most people do with pong clones. I liked how it had a menu and instructions screen and everything. One thing I think could be changed (shouldn''t be too hard), is that when you lose the game, it should go back to the menu and maybe give a message about who won, instead of just closing the application. This makes it so people don''t have to re-open the app to play more than one game. In addition, I think you should be able to go back to the menu by pressing escape. You''ll need to be able to resume your game too if you do that though.

I found the AI to be very difficult. Probably too difficult. I''ve never had the AI miss so far. Maybe this should be taken care of a little as to make the game beatable in one player.

It was difficult to find stuff in your source since it was all in one file... but the game is small enough that I guess it doesn''t matter. First thing I noticed, is that in Game_Init(), you are not deleting those HBITMAPs. You must call DeleteObject() to free up memory used by all those bitmaps. You might be doing this somewhere, but I didn''t notice it. The values are local to the function, so you got to make sure to delete them before the function ends.

Okay... another big problem. Before the game closes because someone won, you play a sound as I can see in the source file. However, you are using SND_ASYNC and calling PostQuitMessage() immediately after, which means the game will exit before playing the sound. To fix this, do not use SND_ASYNC! I''m surprised you didn''t notice this yourself.

Hmmmm... various calls to Sleep(). That''s not good. You should get your own timer system going in there.

Anyway, it was a very fun game. I listed my problems and suggestions above. Overall, the source code was commented well and easy to read, but there are a few problems with it.

Thanks for hearing what you think of the game.
And thanks for pointing out some of the main coding errors.

It would be nice to hear someone elses opinion too...

Lalle