newbie: deleting dynamic arrays??

Werdy666 · 2002-05-13T10:38:33

hi, I'm having afew problems and hope someone can point me in the right direction. First of all some code..... ...... char *tojumble = 0; char *jumbling = 0; int *flag = 0; char *jumbled = 0; ...... ...... class Word { public: std::string word; std::string jumbledword; int Word::num_letters() { return (word.size()); } int Word::jumble() { int letters = Word::num_letters(); jumbling = new char[letters]; flag = new int[letters]; jumbled = new char[letters]; tojumble = new char[letters]; do { for (int t=0; t now if my understanding is correct right before the return 0; i am deleting the arrays i created at the top of my code. My problem is i have a runtime error when i have those 4 delete commands in there. When i comment them out the program works fine. i do have to delete them because i used the new command with the 4 of them but where am i going wrong? Any help would be greatly appreciatted! werdy666 [edited by - werdy666 on May 13, 2002 9:54:30 AM]

For Beginners

Started by werdy666 May 13, 2002 08:51 AM

10 comments, last by werdy666 22 years, 9 months ago

werdy666

Author

743

May 13, 2002 10:29 AM

quote:
Original post by dalleboy
This will not help you, but anyway:

- (jumbled == tojumble) is always false.

Fixed!

- Move the srand out of the loop, or move it out of the method entirely.

Did that too!

- The goto could be replaced by a do-while loop.
int newlocation;do{ newlocation = rand() % letters;} while (flag[newlocation] == 1);flag[newlocation] = 1;jumbled[newlocation] = tojumble[j];

Thanks!

Another thing: Why do you have the tojumble, jumbling, flag and jumbled variables as globals when you always make new/delete on them on each call to jumble()?

ummm cause i am a beginner! lol I have moved them so they are not globals anymore.

thanks for the tips!
[edited by - dalleboy on May 13, 2002 11:20:06 AM]

dalleboy

324

May 13, 2002 10:38 AM

You are welcome....

newbie: deleting dynamic arrays??

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

newbie: deleting dynamic arrays??

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines