Hi Andreas,

here I am again with another question :)

The following code produces a warning which says "Implicit conversion changed sign of value":

       
if ( ( G_PointContents( spawn.origin ) & CONTENTS_NODROP ) != 0 )
...

G_PointContents's declaration is:

int G_PointContents( const Vec3 &in origin )

and CONTENTS_NODROP is an enum. Changing the line to read:

if ( ( G_PointContents( spawn.origin ) & uint( CONTENTS_NODROP ) ) != 0 )

fixes the warning. Why casting an enum to unsigned int fixes the warning, while G_PointContents is obviously a signed integer?

That's a good question. :)

I'll look into it.

ok, thanks!

Hi Andreas,

did you have the chance to look into the problem? I know it's kinda minor but still rather annoying :)

Not yet. I haven't forgotten it though. :)

Fixed in revision 1835.

Regards,

Andreas

Thank you :)

Hm, after updating to WIP Angelscript version, I get loads of the following errors:

dm.as 275:33: No conversion from 'uint' to 'uint' available.
^5ANGELSCRIPT:

legacy/quake1.as 86:1: Compiling void light_fluoro_use(Entity@, Entity@, Entity@)
^1ERROR:

legacy/quake1.as 91:23: No conversion from 'int' to 'int' available.
^3WARNING:

That's bizarre.

Can you show me the script for these funtions?

void item_weapon( Entity @ent )
{
	if( (ent.spawnFlags & WEAPON_ROCKET) == WEAPON_ROCKET )
	{
		if( (ent.spawnFlags & WEAPON_BIG) == WEAPON_BIG )
			GENERIC_SpawnItem( ent, AMMO_ROCKETS );
		else
			GENERIC_SpawnItem( ent, AMMO_WEAK_ROCKETS );	
	}
	else if( (ent.spawnFlags & WEAPON_SPIKES) == WEAPON_SPIKES )
	{
		if( (ent.spawnFlags & WEAPON_BIG) == WEAPON_BIG )
			GENERIC_SpawnItem( ent, AMMO_PLASMA );		
		else
			GENERIC_SpawnItem( ent, AMMO_WEAK_PLASMA );
	}	
	else if( (ent.spawnFlags & WEAPON_SHOTGUN) == WEAPON_SHOTGUN )
	{
		if( (ent.spawnFlags & WEAPON_BIG) == WEAPON_BIG )
			GENERIC_SpawnItem( ent, AMMO_SHELLS );
		else
			GENERIC_SpawnItem( ent, AMMO_WEAK_SHELLS );
	}
}

Basically, each '(ent.spawnFlags & WEAPON_ROCKET) == WEAPON_ROCKET'-style comparison throughout the source code results in compilation error.

WEAPON_ROCKET again is an enum, spawnflags is an integer property.