Great. I took a quick look at it and it looks good.
I'll take a closer look and add some regression tests for the changes to include in the SDK as soon as possible.
Regards,
Andreas
19 users logged in
Proud partner of GDC 2025
Before posting, review our community guidelines.
Support GameDev.net with a monthly GDNet+ subscription!
Custom keyword and object type flag (solved, code attached)
August 21, 2011 02:51 PM
AngelCode.com - game development and more - Reference DB - game developer references
AngelScript - free scripting library - BMFont - free bitmap font generator - Tower - free puzzle game
112
August 24, 2011 04:54 PM
I see you have a method for class variables, but what about class functions? Looks like you got a start on it, but I don't see anything in the code that suggests that it's finding metadata for class functions.
August 24, 2011 05:29 PM
I see you have a method for class variables, but what about class functions? Looks like you got a start on it, but I don't see anything in the code that suggests that it's finding metadata for class functions.
You are correct. That is not yet implemented, since I had no need for it, but should be quite simple to add. Just a matter of adding a few lines where the global functions are added.
September 07, 2011 01:55 PM
I've finally checked in this improvement to the CScriptBuilder add-on. Except for a few minor tweaks and fixes I kept it pretty much as-is.
You'll find the updated version in revision 954.
Thanks a lot for the contribution.
You'll find the updated version in revision 954.
Thanks a lot for the contribution.
AngelCode.com - game development and more - Reference DB - game developer references
AngelScript - free scripting library - BMFont - free bitmap font generator - Tower - free puzzle game
September 14, 2011 11:34 AM
Found a small error in the new code
should be:
Else it will not skip functions in classes properly.
if( currentClass == "" )
pos = SkipStatement(pos);
else
pos += len;
should be:
if( currentClass != "" )
pos = SkipStatement(pos);
else
pos += len;
Else it will not skip functions in classes properly.
September 14, 2011 12:05 PM
Another thing I found. Need to add:
At the end of the section that checks handles the start of class, ie the one that starts with:
Sorry for spamming changes, but seemed so small that was not worth to upload the entire code.
//Skip any white spaces in case meta data follows:
t = engine->ParseToken(&modifiedScript[pos], modifiedScript.size() - pos, &len);
while(t == asTC_COMMENT || t == asTC_WHITESPACE) {
pos += len;
t = engine->ParseToken(&modifiedScript[pos], modifiedScript.size() - pos, &len);
}
At the end of the section that checks handles the start of class, ie the one that starts with:
if( modifiedScript.substr(pos,len) == "class" )
{Sorry for spamming changes, but seemed so small that was not worth to upload the entire code.
September 15, 2011 01:33 AM
Thanks. I'll apply these fixes as soon as possible.
AngelCode.com - game development and more - Reference DB - game developer references
AngelScript - free scripting library - BMFont - free bitmap font generator - Tower - free puzzle game
September 15, 2011 02:54 AM
You were right. The changes were needed, however as I applied them I saw that the code could be cleaned up a bit so I ended up doing it a bit differently.
Here's the diff for revision 958.
Here's the diff for revision 958.
AngelCode.com - game development and more - Reference DB - game developer references
AngelScript - free scripting library - BMFont - free bitmap font generator - Tower - free puzzle game
This topic is closed to new replies.
Advertisement
Popular Topics
Advertisement
Recommended Tutorials
Advertisement