For me, it doesn't bother much if my avatar dies or something similarly bad happens, but
- Before that, the avatar's actions must have achieved something amazing. Something like the truce in Matrix:Revolutions would personally piss me off - I want my enemies crushed...
- Ending must fit the atmosphere of the rest of the game. Max Payne 1/2 do this just right, but actually the games led me to believe than in true noir fashion Max would end up much worse off...
- Must be professionally done - no twists right at the end, when the game itself is already over, just for the sake of being clever.
Probably said this before, but I think Chaser is hard to top in disappointing endings (EDIT: link added) -
http://www.visualwalkthroughs.com/chaser/outro/outro.htm[Edited by - AgentC on August 1, 2005 2:03:53 PM]